Can I please get an approval on that one? It’s been there since January, I’ve amended it following review, but cannot get a definite ok. It is five lines.
Bootstrapped on x86_64-apple-darwin23. OK to push? FX > Le 7 sept. 2024 à 19:35, FX Coudert <fxcoud...@gmail.com> a écrit : > > ping**many on this patch, originally from January. > In latest round, Richard suggested that David should have the last say, I’ve > never had any response. > > >> Le 27 juin 2024 à 19:08, FX Coudert <fxcoud...@gmail.com> a écrit : >> >> Among the review comments from the last round, Jakub suggested: >> >>> Perhaps libgccjit.h could use >>> #ifdef __has_include >>> #if __has_include (<sys/types.h>) >>> #include <sys/types.h> >>> #endif >>> #endif >>> instead of just #include <sys/types.h>. >> >> I’m not sure it’s necessary since other headers treat <sys/types.h> as >> always available, but I suppose it can’t hurt. So here is a revised patch as >> suggested. >> >> >> Bootstrapped on x86_64-apple-darwin23. OK to push? >> >> FX
0001-jit-Ensure-ssize_t-is-defined.patch
Description: Binary data
