Ok
On Thu, Sep 5, 2024, 09:30 Jakub Jelinek <ja...@redhat.com> wrote:
> Hi!
>
> I've noticed non-standard wording of this diagnostics when looking at
> a miscompilation with --param=vrp-block-limit=0.
>
> Diagnostics generally shouldn't start with uppercase letter (unless
> the upper case would appear also in the middle of a sentence) and shouldn't
> be separate sentences with dot as separator, ; is IMHO more frequently
> used.
>
> Ok for trunk?
>
> 2024-09-05 Jakub Jelinek <ja...@redhat.com>
>
> * tree-vrp.cc (pass_vrp::execute): Start diagnostics with
> lowercase u rather than capital U, use semicolon instead of dot.
>
> --- gcc/tree-vrp.cc.jj 2024-07-01 11:28:23.489227914 +0200
> +++ gcc/tree-vrp.cc 2024-09-04 21:26:35.693634896 +0200
> @@ -1337,7 +1337,7 @@ public:
> {
> use_fvrp = true;
> warning (OPT_Wdisabled_optimization,
> - "Using fast VRP algorithm. %d basic blocks"
> + "using fast VRP algorithm; %d basic blocks"
> " exceeds %<--param=vrp-block-limit=%d%> limit",
> n_basic_blocks_for_fn (fun),
> param_vrp_block_limit);
>
> Jakub
>
>
