> -----Original Message-----
> From: Gerald Pfeifer <ger...@pfeifer.com>
> Sent: Saturday, August 10, 2024 6:33 PM
> To: Liu, Hongtao <hongtao....@intel.com>
> Cc: gcc-patches@gcc.gnu.org; crazy...@gmail.com; hjl.to...@gmail.com
> Subject: Re: [PATCH] [x86] Mention _Float16 and __bf16 changes in GCC14.
> 
> On Wed, 31 Jul 2024, liuhongt wrote:
> > +  <li> The <code>_Float16</code> and <code>__bf16</code> type are
> supported
> > +    independent of SSE2. W/o SSE2, these types are storage-only, compiler
> will
> > +    issue an error when they're used in conversion, unary operation,
> > +    binary operation, parameter passing or value return.
> 
> "types" (plural)
> "independently"
> "Without" (spelt out)
> "the compiler"
> 
> And personally I would use an Oxford comma, so "..., or value return".
> 
> > +    instead of <code>__FLT16_MAX__</code>(or other similar Macros).
> 
> "macros" (lowercase)
> 
> 
> --- a/htdocs/gcc-14/porting_to.html
> +++ b/htdocs/gcc-14/porting_to.html
> 
> I don't think we need this in porting_to.html as well; the release notes are
> sufficient.
> 
> 
> This patch is okay with the changes above. I see this is already
> committed. Can you please make them as follow-up? Or should I?
Could you help to refine the words, much thanks for that.
> 
> Thanks,
> Gerald

Reply via email to