Hi Martin,

On Tue, Aug 06, 2024 at 04:43:27PM GMT, Martin Uecker wrote:
> > When running `make check -j24 -Orecurse |& tee log`, this is what I see:
> > 
> >             FAIL: gcc.dg/lengthof-compile.c (test for excess errors)
> > 
> > Is there any way to see more details?
> 
> See gcc/testsuite/gcc/gcc.log 

Ahhh, thanks!  It seems it was only the obvious C90-compat warnings that
I need to turn off.  It all seems good after that.

FAIL: gcc.dg/lengthof-compile.c (test for excess errors)
Excess errors:
/home/alx/src/gnu/gcc/len/gcc/testsuite/gcc.dg/lengthof-compile.c:22:9: error: 
ISO C90 does not support flexible array members [-Wpedantic]
/home/alx/src/gnu/gcc/len/gcc/testsuite/gcc.dg/lengthof-compile.c:30:1: error: 
ISO C90 forbids variable length array 'a' [-Wvla]
/home/alx/src/gnu/gcc/len/gcc/testsuite/gcc.dg/lengthof-compile.c:31:33: error: 
ISO C90 does not support '[*]' array declarators [-Wpedantic]

> 
> There are also *.sum files which you can diff against a build
> without your patch to see whether there are any regressions.

Good.  I'll check.

> > > > -  I don't like the fact that [*][n] is internally implemented exactly
> > > >    like [0][n], which makes them indistinguishable.  All other cases of
> > > >    [0] return a constent expression of value 0, but [0][n] must return a
> > > >    variable 0, to keep support for [*][n].
> > > >    Could you please change the way [*][n] (and thus [*]) is represented
> > > >    internally so that it can be differentiated from [0]?
> > > >    Do you have in mind any other way that would be a viable
> > > >    implementation of [*] that would allow distinguishing [0][n] and
> > > >    [*][n]?  Maybe making it to have one node instead of zero and mark
> > > >    that node specially?
> > > 
> > > The C++ frontend encodes zero-sized arrays using a range of [0,-1]. 
> > > I have a half-finished patch which implements this for the C FE.
> > 
> > Thanks!  I guess your patch will be merged before mine, so please ping
> > me when that happens so I update mine for it.
> 
> Not sure about this...

:)

> > 
> > BTW, do you allow me to use Co-developed-by: you?
> 
> ok,

Thanks!

Cheers,
Alex

> Martin
> > 
> > Have a lovely day!
> > Alex

-- 
<https://www.alejandro-colomar.es/>

Attachment: signature.asc
Description: PGP signature

Reply via email to