On Wed, 31 Jul 2024 at 16:45, Sam James <s...@gentoo.org> wrote:
>
> We already have a valid 'dg-do run' (- vs _) directive, so drop the bogus
> one.
>
> libstdc++-v3/ChangeLog:
>         * testsuite/28_regex/traits/char/translate.cc: Drop bogus 'dg_do run'.
> ---
> OK? No regressions in the logs but it's a bit weird that it's got a proper
> directive with a target specifier so I thought I'd check rather than doing
> it as obvious.

Definitely OK. Dejagnu will ignore it because it doesn't start with
dg- so it is useless.

Even if it was used, it would be wrong because std::regex can't be
used in C++98 so the c++11 effective target is needed.


>
>  libstdc++-v3/testsuite/28_regex/traits/char/translate.cc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc 
> b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> index e2552e3cbf05..65119e67e25b 100644
> --- a/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> +++ b/libstdc++-v3/testsuite/28_regex/traits/char/translate.cc
> @@ -1,4 +1,3 @@
> -// { dg_do run }
>  // { dg-do run { target c++11 } }
>  // { dg-timeout-factor 2 }
>
>
> --
> 2.45.2
>

Reply via email to