Hi,
Checking the existing powerpc_{altivec,vsx}_ok test cases,
I found there are some test cases which don't require the
checks powerpc_{altivec,vsx} even, some of them already
have other effective target check which can cover check
powerpc_{altivec,vsx}, or some of them don't actually
require VSX/AltiVec feature at all. So this patch is to
remove such useless checks.
Bootstrapped and regtested on powerpc64-linux-gnu P8/P9 and
powerpc64le-linux-gnu P9 and P10.
I'm going to push this next week if no objections.
BR,
Kewen
----
PR testsuite/114842
gcc/testsuite/ChangeLog:
* gcc.target/powerpc/amo2.c: Remove powerpc_vsx_ok effective target
check as p9vector_hw already covers it.
* gcc.target/powerpc/p9-sign_extend-runnable.c: Likewise.
* gcc.target/powerpc/clone2.c: Remove powerpc_vsx_ok effective target
check as ppc_cpu_supports_hw already covers it.
* gcc.target/powerpc/pr47251.c: Remove powerpc_vsx_ok effective target
check as it doesn't need VSX.
* gcc.target/powerpc/pr60137.c: Likewise.
* gcc.target/powerpc/pr80098-1.c: Likewise.
* gcc.target/powerpc/pr80098-2.c: Likewise.
* gcc.target/powerpc/pr80098-3.c: Likewise.
* gcc.target/powerpc/sd-pwr6.c: Likewise.
* gcc.target/powerpc/pr57744.c: Remove powerpc_vsx_ok effective target
check and option -mvsx as it doesn't need VSX.
* gcc.target/powerpc/pr69548.c: Remove powerpc_vsx_ok effective target
check as it doesn't need VSX, remove lp64 and use int128 instead.
* gcc.target/powerpc/vec-cmpne-long.c: Remove powerpc_vsx_ok effective
target check as p8vector_hw already covers it.
* gcc.target/powerpc/darwin-save-world-1.c: Remove powerpc_altivec_ok
effective target check as vmx_hw already covers it.
---
gcc/testsuite/gcc.target/powerpc/amo2.c | 1 -
gcc/testsuite/gcc.target/powerpc/clone2.c | 1 -
gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c | 2 +-
gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c | 1 -
gcc/testsuite/gcc.target/powerpc/pr47251.c | 1 -
gcc/testsuite/gcc.target/powerpc/pr57744.c | 3 +--
gcc/testsuite/gcc.target/powerpc/pr60137.c | 1 -
gcc/testsuite/gcc.target/powerpc/pr69548.c | 6 +++---
gcc/testsuite/gcc.target/powerpc/pr80098-1.c | 1 -
gcc/testsuite/gcc.target/powerpc/pr80098-2.c | 1 -
gcc/testsuite/gcc.target/powerpc/pr80098-3.c | 1 -
gcc/testsuite/gcc.target/powerpc/sd-pwr6.c | 1 -
gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c | 1 -
13 files changed, 5 insertions(+), 16 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/amo2.c
b/gcc/testsuite/gcc.target/powerpc/amo2.c
index 9cb493da53e..592f0fb3f92 100644
--- a/gcc/testsuite/gcc.target/powerpc/amo2.c
+++ b/gcc/testsuite/gcc.target/powerpc/amo2.c
@@ -1,5 +1,4 @@
/* { dg-do run { target { powerpc*-*-linux* && { lp64 && p9vector_hw } } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-O2 -mvsx -mpower9-misc" } */
/* { dg-additional-options "-mdejagnu-cpu=power9" { target { ! has_arch_pwr9 }
} } */
diff --git a/gcc/testsuite/gcc.target/powerpc/clone2.c
b/gcc/testsuite/gcc.target/powerpc/clone2.c
index e64940b7952..4098e878c21 100644
--- a/gcc/testsuite/gcc.target/powerpc/clone2.c
+++ b/gcc/testsuite/gcc.target/powerpc/clone2.c
@@ -1,6 +1,5 @@
/* { dg-do run { target { powerpc*-*-linux* } } } */
/* { dg-options "-mvsx -O2" } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-require-effective-target ppc_cpu_supports_hw } */
#include <stddef.h>
diff --git a/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c
b/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c
index 3326765f4fb..27fc1d30a8b 100644
--- a/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c
@@ -1,7 +1,7 @@
/* { dg-do run { target powerpc*-*-* } } */
/* { dg-options "-maltivec" } */
/* { dg-require-effective-target powerpc_altivec } */
-/* { dg-skip-if "need to be able to execute AltiVec" { ! { powerpc_altivec_ok
&& vmx_hw } } } */
+/* { dg-skip-if "need to be able to execute AltiVec" { ! vmx_hw } } */
/* With altivec turned on, Darwin wants to save the world but we did not mark
lr as being saved any more
as saving the lr is not needed for saving altivec registers. */
diff --git a/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
index f0514993bc0..595aa4768cc 100644
--- a/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
@@ -1,5 +1,4 @@
/* { dg-do run { target { *-*-linux* && { lp64 && p9vector_hw } } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-O2 -mdejagnu-cpu=power9 -mvsx -save-temps" } */
/* These builtins were not defined until ISA 3.1 but only require ISA 3.0
diff --git a/gcc/testsuite/gcc.target/powerpc/pr47251.c
b/gcc/testsuite/gcc.target/powerpc/pr47251.c
index bb7ea64ff08..b4bcec58398 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr47251.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr47251.c
@@ -1,6 +1,5 @@
/* { dg-do compile { target { powerpc*-*-* && ilp32 } } } */
/* { dg-skip-if "" { powerpc*-*-darwin* } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-O2 -msoft-float -mdejagnu-cpu=power7" } */
/* PR 47151: libgcc fails to build when using --with-cpu=power7 due to a missed
diff --git a/gcc/testsuite/gcc.target/powerpc/pr57744.c
b/gcc/testsuite/gcc.target/powerpc/pr57744.c
index 9e51dc7fb9c..73f524580ac 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr57744.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr57744.c
@@ -1,7 +1,6 @@
/* { dg-do run { target { powerpc*-*-* && lp64 } } } */
/* { dg-skip-if "" { powerpc*-*-darwin* } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
-/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3" } */
+/* { dg-options "-mdejagnu-cpu=power8 -O3" } */
void abort (void);
diff --git a/gcc/testsuite/gcc.target/powerpc/pr60137.c
b/gcc/testsuite/gcc.target/powerpc/pr60137.c
index 1b1b69aab39..d91079f608b 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr60137.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr60137.c
@@ -1,6 +1,5 @@
/* { dg-do compile { target { powerpc*-*-* } } } */
/* { dg-skip-if "" { powerpc*-*-darwin* } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3 -mno-vsx" } */
/* target/60137, compiler got a 'could not split insn error'. */
diff --git a/gcc/testsuite/gcc.target/powerpc/pr69548.c
b/gcc/testsuite/gcc.target/powerpc/pr69548.c
index 259d8d287c0..287b38ffabb 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr69548.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr69548.c
@@ -1,7 +1,7 @@
-/* { dg-do assemble { target { powerpc*-*-* && lp64 } } } */
+/* { dg-do assemble } */
/* { dg-skip-if "" { powerpc*-*-darwin* } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
-/* { dg-options "-mdejagnu-cpu=power8 -mvsx -Os -mbig" } */
+/* { dg-require-effective-target int128 } */
+/* { dg-options "-mdejagnu-cpu=power8 -Os -mbig" } */
__int128
quad_exchange (__int128 *ptr, __int128 newval)
diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-1.c
b/gcc/testsuite/gcc.target/powerpc/pr80098-1.c
index f22c8d93fb4..f7f3dfdcb3c 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr80098-1.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr80098-1.c
@@ -1,5 +1,4 @@
/* { dg-do compile { target { powerpc64*-*-* } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mdejagnu-cpu=power9 -mno-vsx -mpower9-minmax" } */
int i;
diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-2.c
b/gcc/testsuite/gcc.target/powerpc/pr80098-2.c
index 964b849111b..c42200e6d3c 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr80098-2.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr80098-2.c
@@ -1,5 +1,4 @@
/* { dg-do compile { target { powerpc64*-*-* } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mdejagnu-cpu=power8 -mno-vsx -mcrypto" } */
int i;
diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-3.c
b/gcc/testsuite/gcc.target/powerpc/pr80098-3.c
index 5dcae1a8b7c..d8023c0707f 100644
--- a/gcc/testsuite/gcc.target/powerpc/pr80098-3.c
+++ b/gcc/testsuite/gcc.target/powerpc/pr80098-3.c
@@ -1,5 +1,4 @@
/* { dg-do compile { target { powerpc64*-*-* } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mdejagnu-cpu=power7 -mno-vsx -mcrypto" } */
int i;
diff --git a/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c
b/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c
index 55b32a9115e..e2775fcb530 100644
--- a/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c
+++ b/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c
@@ -1,6 +1,5 @@
/* { dg-do compile { target { powerpc*-*-* } } } */
/* { dg-skip-if "" { powerpc*-*-darwin* powerpc-ibm-aix* } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-require-effective-target dfp } */
/* { dg-options "-O2 -mdejagnu-cpu=power6 -mhard-dfp" } */
/* { dg-final { scan-assembler-not "lfiwzx" } } */
diff --git a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c
b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c
index 7086156bef8..9ccf1b544d0 100644
--- a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c
+++ b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c
@@ -1,5 +1,4 @@
/* { dg-do run { target { powerpc64*-*-* && { p8vector_hw } } } } */
-/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3" } */
/* Test that the vec_cmpne builtin works as expected for long long
--
2.43.5
