On Wed, 24 Jul 2024 at 22:51, Jonathan Wakely <jwak...@redhat.com> wrote: > > Tested x86_64-linux. > > Any reason not to do this? I don't think the assertions are useful to > catch implementation bugs where we access the contained value without > checking it - we should use tests for that.
Looks good to me. > The current assertions also result in repeated invalid bug reports, such > as PR 91281, PR 101659, PR 102712, and PR 107894. I'm not sure moving the assertions helps with that, maybe some of those bug reports are caused by people not knowing how to enable the assertions.
