On Wed, Jul 17, 2024 at 10:27:53AM +0100, Sam James wrote:
> All of these are for wrong-code bugs. Confirmed to be used before but
> with no execution.
>
> 2024-07-17 Sam James <s...@gentoo.org>
2 spaces instead of one before <.
>
> PR/96369
> PR/102124
> PR/108692
> * c-c++-common/pr96369.c: Add dg-do run directive.
> * gcc.dg/torture/pr102124.c: Ditto.
> * gcc.dg/pr108692.c: Ditto.
> ---
> Inspired by Jakub's fixes earlier for other missing dg-run tests which clearly
> needed execution.
>
> Please commit if OK. Thanks.
>
> gcc/testsuite/c-c++-common/pr96369.c | 1 +
> gcc/testsuite/gcc.dg/pr108692.c | 1 +
> gcc/testsuite/gcc.dg/torture/pr102124.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/c-c++-common/pr96369.c
> b/gcc/testsuite/c-c++-common/pr96369.c
> index 8c468d9fec2f..9cb5aaa50420 100644
> --- a/gcc/testsuite/c-c++-common/pr96369.c
> +++ b/gcc/testsuite/c-c++-common/pr96369.c
> @@ -1,4 +1,5 @@
> /* { dg-do compile } */
> +/* { dg-do run } */
Please don't do this.
If the test should be run, there shouldn't be dg-do compile (exception is
if the two dg-do directives are conditional on effective targets or similar
and you want the test to be dg-do compile in some cases and dg-do run in
other).
> /* { dg-options "-O" } */
>
> int main()
> diff --git a/gcc/testsuite/gcc.dg/pr108692.c b/gcc/testsuite/gcc.dg/pr108692.c
> index fc25bf54e45d..e5f8af5669bb 100644
> --- a/gcc/testsuite/gcc.dg/pr108692.c
> +++ b/gcc/testsuite/gcc.dg/pr108692.c
> @@ -1,5 +1,6 @@
> /* PR tree-optimization/108692 */
> /* { dg-do compile } */
> +/* { dg-do run } */
Ditto.
> /* { dg-options "-O2 -ftree-vectorize" } */
>
> __attribute__((noipa)) int
> diff --git a/gcc/testsuite/gcc.dg/torture/pr102124.c
> b/gcc/testsuite/gcc.dg/torture/pr102124.c
> index a158b4a60b69..a0eb01521242 100644
> --- a/gcc/testsuite/gcc.dg/torture/pr102124.c
> +++ b/gcc/testsuite/gcc.dg/torture/pr102124.c
> @@ -1,4 +1,5 @@
> /* PR tree-optimization/102124 */
> +/* { dg-do run } */
>
> int
> foo (const unsigned char *a, const unsigned char *b, unsigned long len)
>
> --
> 2.45.2
Jakub
