GCC maintainers: version 4: Additional dg option updates per the feedback. Retested the patch on Power 10, no regressions.
version 3: Updated per the feedback from Peter, Kewen and Segher. Note, Peter suggested the -mdejagnu-cpu= value must be power7. The test fails if -mdejagnu-cpu= is set to power7, needs to be power8. Patch has been retested on a Power 10 box, it succeeds with 2 passes and no fails. Per the additional feedback after patch: commit c892525813c94b018464d5a4edc17f79186606b7 Author: Carl Love <c...@linux.ibm.com> Date: Tue Jun 11 14:01:16 2024 -0400 rs6000, altivec-2-runnable.c should be a runnable test The test case has "dg-do compile" set not "dg-do run" for a runnable test. This patch changes the dg-do command argument to run. gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog: * gcc.target/powerpc/altivec-2-runnable.c: Change dg-do argument to run. was approved and committed, I have updated the dg-require-effective-target and dg-options as requested so the test will compile with -O2 on a machine that has a minimum support of Power 8 vector hardware. The patch has been tested on Power 10 with no regression failures. Please let me know if this patch is acceptable for mainline. Thanks. Carl ---------------------------------------------------------------------------------- rs6000, altivec-2-runnable.c update the require-effective-target The test requires a minimum of Power8 vector HW and a compile level of -O2. Update the dg test directives. gcc/testsuite/ChangeLog:gcc/testsuite/ChangeLog: * gcc.target/powerpc/altivec-2-runnable.c: Change the require-effective-target for the test. --- gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c index 17b23eb9d50..660669f69fd 100644 --- a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c @@ -1,6 +1,6 @@ -/* { dg-do run } */ -/* { dg-options "-mvsx" } */ -/* { dg-additional-options "-mdejagnu-cpu=power8" { target { ! has_arch_pwr8 } } } */ +/* { dg-do run { target p8vector_hw } } */ +/* { dg-do compile { target { ! p8vector_hw } } } */ +/* { dg-options "-O2 -mdejagnu-cpu=power8" } */ /* { dg-require-effective-target powerpc_vsx } */ #include <altivec.h> -- 2.45.0