Andi Kleen <a...@linux.intel.com> writes: > FWIW I suspect not handling lockfile errors could be a show stopper > even for an initial implementation. It's not that uncommon that people > press Ctrl-C. flock on systems that have it would be a safer > alternative. > >> There are many things to do and I think it is better to do that in trunk >> rahter than cumulating relatively complex changes on branch. >> md5 is already supported by libiberty so it is kind of easy choice for >> first cut implementation. > > At least use sha1 then. This is also in libiberty and it has hardware > acceleration on modern x86.
I have to say I agree here -- although I'd still want to switch to a proper non-cryptographic hash later. Note that it wasn't in libiberty when this work was started, IIRC, but it is now. > > -Andi
