On 21/06/2024 16:30, Tobias Burnus wrote:
[I messed up copying from the build system, picking up an old version.
Changes to v1 (bottom of the diff): fopen is no longer required.]

Tobias Burnus wrote:
mkoffload's generated .c file looks much nicer with '#embed'.

This patch depends on Jakub's #embed patch at
https://gcc.gnu.org/pipermail/gcc-patches/2024-June/655012.html

It might be a tiny bit faster than currently (or not); however,
once #embed has a large-file mode, it should also speed up
the offloading compilation quit a bit.

OK for mainline, once '#embed' support is in?
Tobias


   /* Dump out an array containing the binary.
      FIXME: do this with objcopy.  */

Please adjust that comment; the FIXME can be removed completely.

Otherwise LGTM, thanks. :-)

Andrew

Reply via email to