Hi!
on 2024/6/14 05:16, Carl Love wrote:
> Segher:
>
> On 6/13/24 12:51, Segher Boessenkool wrote:
>
> <snip>
>
>>
>>> --- a/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c
>>> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-2-runnable.c
>>> @@ -1,4 +1,4 @@
>>> -/* { dg-do compile { target powerpc*-*-* } } */
>>> +/* { dg-do run { target powerpc*-*-* } } */
>>> /* { dg-options "-mvsx" } */
>>> /* { dg-additional-options "-mdejagnu-cpu=power8" { target { !
>>> has_arch_pwr8 } } } */
>>> /* { dg-require-effective-target powerpc_vsx } */
>>
>> Everything in gcc.target/powerpc/ is tested for "target powerpc*-*-*"
>> already, so you could remove that target clause even (after testing of
>> course :-) )
>>
>> Okay for trunk with or without that extra tweak. Thank you!
>
> I updated the patch by removing the target clause as suggested:
>
> -/* { dg-do compile { target powerpc*-*-* } } */
> +/* { dg-do run } */
> /* { dg-options "-mvsx" } */
> /* { dg-additional-options "-mdejagnu-cpu=power8" { target { ! has_arch_pwr8
> } } } */
> /* { dg-require-effective-target powerpc_vsx } */
Since you changed this for "run", I think you also want s/powerpc_vsx/vsx_hw/ .
BR,
Kewen
>
> Retested on Power 10. Reports 2 passes and no failures. I will go ahead and
> commit.
>
> Thanks.
>
> Carl
