On Sun, 2 Jun 2024, Kewen Lin wrote:
> This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE
> defines in mmix port.
This is fine once prerequisites are in place.
If I may add a nit: In these target change commit messages, add
a hint as to which defaulted hook or macro the removed macro now
corresponds to, like "these now correspond to the default values
of the new target hook mode_for_floating_type". Else when doing
port archaeology, from the commit message it looks like the
context has not changed, you just removed some definitions.
>
> gcc/ChangeLog:
>
> * config/mmix/mmix.h (FLOAT_TYPE_SIZE): Remove.
> (DOUBLE_TYPE_SIZE): Likewise.
> (LONG_DOUBLE_TYPE_SIZE): Likewise.
> ---
> gcc/config/mmix/mmix.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/gcc/config/mmix/mmix.h b/gcc/config/mmix/mmix.h
> index c3c5a2a69c9..e20bca1d363 100644
> --- a/gcc/config/mmix/mmix.h
> +++ b/gcc/config/mmix/mmix.h
> @@ -195,10 +195,6 @@ struct GTY(()) machine_function
> #define SHORT_TYPE_SIZE 16
> #define LONG_LONG_TYPE_SIZE 64
>
> -#define FLOAT_TYPE_SIZE 32
> -#define DOUBLE_TYPE_SIZE 64
> -#define LONG_DOUBLE_TYPE_SIZE 64
> -
> #define DEFAULT_SIGNED_CHAR 1
>
>
> --
> 2.43.0
>
>
