On Fri, 29 Mar 2024, Qing Zhao wrote:
> +/* For a SUBDATUM field of a structure or union DATUM, generate a REF to
> + the object that represents its counted_by per the attribute counted_by
> + attached to this field if it's a flexible array member field, otherwise
> + return NULL_TREE.
> + set COUNTED_BY_TYPE to the TYPE of the counted_by field.
Use an uppercase letter at the start of a sentence, "Set".
> +static tree
> +build_counted_by_ref (tree datum, tree subdatum, tree *counted_by_type)
> +{
> + tree type = TREE_TYPE (datum);
> + if (!(c_flexible_array_member_type_p (TREE_TYPE (subdatum))))
> + return NULL_TREE;
There are redundant parentheses here around the call to
c_flexible_array_member_type_p.
The C front-end changes in this patch are OK for GCC 15 (after GCC 14 has
branched, and once a version of patch 1 has also been approved) with those
fixes.
--
Joseph S. Myers
[email protected]