On 10/01/2024 21:26, Jonny Grant wrote:
>
>
> On 03/12/2023 17:55, David Malcolm wrote:
>> On Sun, 2023-12-03 at 11:59 +0000, Jonny Grant wrote:
>>>
>>>
>>> On 03/12/2023 04:03, Xi Ruoyao wrote:
>>>> On Sun, 2023-12-03 at 00:17 +0000, Jonny Grant wrote:
>>>>> @@ -733,7 +733,7 @@ To configure GCC:
>>>>> @smallexample
>>>>> % mkdir @var{objdir}
>>>>> % cd @var{objdir}
>>>>> -% @var{srcdir}/configure [@var{options}] [@var{target}]
>>>>> +% ../@var{srcdir}/configure [@var{options}] [@var{target}]
>>>>> @end smallexample
>>>>
>>>> No, this is definitely incorrect. srcdir is the path (it may be
>>>> relative or absolute) to the GCC source tree. It's not necessary
>>>> to be
>>>> placed in the parent directory of objdir.
>>>>
>>>
>>> Fair enough.
>>>
>>> Can the spelling corrections still be merged? Or should I re-submit
>>> the patch without that line?
>>
>> The spelling corrections look OK to me.
>>
>> Do you have an account that can push commits, or would you need this
>> done for you?
>>
>> Please can you add Signed-off-by lines to your patches/commits
>> (via -s); see https://gcc.gnu.org/dco.html
>>
>> Thanks
>> Dave
>
> Hi Dave
>
> Would need someone to push the commits as I don't have an account.
>
> I'll use -s for next patches, I've emailed again with the line added:
>
> Signed-off-by: Jonathan Grant <j...@jguk.org>
>
> Thanks, Jonny
Hi Dave
May I ask for review of my revised patch please.
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642539.html
Kind regards, Jonny
