On Tuesday, January 9th, 2024 at 1:58 PM, Jason Merrill <ja...@redhat.com> wrote:
> > > On 1/6/24 19:00, waffl3x wrote: > > > Bootstrapped and tested on x86_64-linux with no regressions. > > > > I'm considering this finished, I have CWG2586 working but I have not > > included it in this version of the patch. I was not happy with the > > amount of work I had done on it. I will try to get it finished before > > we get cut off, and I'm pretty sure I can. I just don't want to risk > > missing the boat for the whole patch just for that. > > > > There aren't too many changes from v7, it's mostly just cleaned up. > > There are a few though, so do take a look, if there's anything severe I > > can rush to fix it if necessary. > > > > That's all, hopefully all is good, fingers crossed. > > > Great. Given where we are in the release cycle, I'm thinking to put > these with only minimal changes and then do any further adjustments > afterward. > > For this first one, I needed to fix the commit message to wrap at 75 > columns so that it fits in 80 columns with the initial padding added by > 'git log'. I also needed to adjust the ChangeLog entry to please git > gcc-verify. And I changed the credit note to a Co-authored-by. > > The other commit messages only needed wrapping. > > Thanks! > > Jason Sounds good to me, it's been a pleasure working with you. If there's anything you would like me to do differently for future patches just let me know. For now, I think I will take a break. Alex
