Jeff Law <jeffreya...@gmail.com> writes:
>>> +
>>> +/* Initialization of the ext-dce pass. Primarily this means
>>> + setting up the various bitmaps we utilize. */
>>> +
>>> +static void
>>> +ext_dce_init (void)
>>> +{
>>> +
>>
>> Nit: excess blank line.
> Various nits have been fixed. I think those are all mine. For reasons
> I don't understand to this day, my brain thinks there should be vertical
> whitespace between the function comment and the definition. I'm
> constantly having to fix that.
Yeah, I've never known whether a blank line is preferred between the
comment and function definition. When I started (obviously somewhat
later than you :)), "yes" seemed to be much more common, but now it's
pretty mixed. So I just do what surrounding code does. (Personally
I slightly prefer the blank line.)
So I wasn't commenting on that part, although reading it back, I can
see how it looked like that. It was just on the blank line immediately
above, after the opening "{". I.e. there were some instances of:
void
f (void)
{
...foo...;
}
rather than:
void
f (void)
{
...foo...;
}
Thanks,
Richard
