On Mon, 18 Dec 2023, Jakub Jelinek wrote: > Hi! > > The following patch changes -Walloc-size warning to no longer warn > about int *p = calloc (1, sizeof (int));, because as discussed earlier, > the size is IMNSHO sufficient in that case, for alloc_size with 2 > arguments warns if the product of the 2 arguments is insufficiently small. > > Also, it warns also for explicit casts of malloc/calloc etc. calls > rather than just implicit, so not just > int *p = malloc (1); > but also > int *p = (int *) malloc (1); > > It also fixes some ICEs where the code didn't verify the alloc_size > arguments properly (Walloc-size-5.c testcase ICEs with vanilla trunk). > > And lastly, it introduces a coding style warning, -Wcalloc-transposed-args > to warn for calloc (sizeof (struct S), 1) and similar calls (regardless > of what they are cast to, warning whenever first argument is sizeof and > the second is not). > > Ok for trunk if this passes bootstrap/regtest?
OK. -- Joseph S. Myers jos...@codesourcery.com
