Committed with below comments, thanks Juzhe and Robin. Pan
-----Original Message----- From: Robin Dapp <rdapp....@gmail.com> Sent: Wednesday, December 13, 2023 9:56 PM To: Li, Pan2 <pan2...@intel.com>; gcc-patches@gcc.gnu.org Cc: rdapp....@gmail.com; juzhe.zh...@rivai.ai Subject: Re: [PATCH v1] RISC-V: Refine test cases for both PR112929 and PR112988 Thanks, LGTM but please add a comment like: These test cases used to cause out-of-bounds writes to the stack and therefore showed unreliable behavior. Depending on the execution environment they can either pass or fail. As of now, with the latest QEMU version, they will pass even without the underlying issue fixed. As the test case is known to have caused the problem before we keep it as a run test case for future reference. Regards Robin
