On Mon, Oct 23, 2023 at 02:18:39PM +0100, Iain Sandoe wrote:
> This is a partial reversion of r14-4825-g6a6d3817afa02b to remove an
> unintended change.
>
> Tested with x86_64-linux X arm-none-eabi (and x86_64-darwin X arm-non-eabi
> and native x86_64-darwin bootstrap. Also reported by the OP to fix the
> issue, pushed to trunk, apologies for the breakage,
> Iain
>
> --- 8< ---
>
> This was a rebase error, that managed to pass testing on Darwin and
> Linux (but fails on bare metal).
>
> PR libquadmath/111928
>
> libquadmath/ChangeLog:
>
> * Makefile.in: Regenerate.
> * configure: Regenerate.
> * configure.ac: Remove AC_CHECK_LIBM.
I'm afraid this change is very harmful on Linux.
libquadmath.so.0 had on Linux since forever
0x0000000000000001 (NEEDED) Shared library: [libm.so.6]
entry (and it should have it, because it has undefined relocations against
libm.so.6 entrypoints: at least signgam and sqrt, on powerpc64le also
__sqrtieee128.
But with this change it no longer has.
This e.g. breaks libtool build on powerpc64le, where the dynamic linker
crashes during sqrt related IFUNC resolution.
Jakub
