On Thu, Dec 07, 2023 at 11:02:58AM +0800, Xi Ruoyao wrote:
>
> I don't like this pair of {} for the for statement. It's not necessary
> and it changes the indent level, causing the diff hard to review.
>
> Otherwise LGTM. I'm not sure why I didn't notice the eh_return issue
> when I learnt shrink wrapping from RISC-V...
>
Thanks for the review! This problem on LoongArch was first noticed in a
failed libphobos test case, and the fix is partially borrowed from i386,
which seemed to be the only architecture without this issue.
So despite the extra braces (which I'd say I prefer to have because of the
new block of comment inserted on top of the if statement :P), I am going to
ask Lulu for pushing this.
Yujie
