On Tue, Dec 5, 2023 at 10:46 AM Jonathan Wakely <jwak...@redhat.com> wrote: > > On Mon, 4 Dec 2023 at 16:42, Will Hawkins wrote: > > > > Hello! > > > > Thank you, as always, for the great work that you do on libstdc++. The > > inout_ptr implementation properly handles the issue raised in LWG 3897 > > but it seems like having an explicit test might be a good idea. > > Thanks, Will, we should definitely have a test for this. > > I've tweaked it a bit to avoid leaking the pointer (in case anybody > runs the tests under valgrind or ASan) and to add your new test to the
Of course ... how could I forget to delete the pointer? I'm a goofball. > existing file (to avoid the overhead of a separate test just for this > one check). Makes perfect sense. I wasn't sure how you typically handle that. I will know for the future. > > See attached ... Thank you for the feedback! I look forward to the next time I can help! Will