On Nov 29, 2023, Jason Merrill <ja...@redhat.com> wrote: > On 11/29/23 04:39, Alexandre Oliva wrote: >> Hello, Jason, >> On Nov 22, 2023, Jason Merrill <ja...@redhat.com> wrote: >> >>> On 11/22/23 13:12, Jason Merrill wrote: >>>> I'm coming to the conclusion that your C++ patch is fine but we >>>> should remove the TYPE_PACKED warning from >>>> check_address_or_pointer_of_packed_member. And maybe add >>>> -Wcast-align=strict to -Wextra. >> >>> Since I seem to have opinions, I'm preparing a patch for this. >> Thanks for that patch. It makes sense to me, but I suppose that, if >> it goes in, I should revert the already-installed #1/4 in this series >> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637244.html >> rather than install #4/4 that Mike approved. >> https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637336.html >> I wasn't sure whether your earlier conclusion (quoted above) was >> meant >> as an 'Ok' for the C++ patch. Please confirm if so. TIA,
> Yes. Thanks, the C++ patch is now in, and so is the testsuite patch reversal. The pr108251 analyzer tests are again failing on -fshort-enum platforms, in hope that your patchset is going to make it. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive
