On Nov 20, 2023, David Malcolm <dmalc...@redhat.com> wrote: > On Sun, 2023-11-19 at 04:39 -0300, Alexandre Oliva wrote: >> >> On platforms that enable -fshort-enums by default, various switch- >> enum >> analyzer tests fail, because apply_constraints_for_gswitch doesn't >> expect the integral promotion type cast. I've arranged for the code >> to cope with those casts.
> Thanks for the patch, and sorry for the failing tests. No worries. > Which tests failed? I'm guessing one of the ones from r13-5159- > gccd4df81aa6537. Yeah, I'm afraid I didn't take notes about which tests failed (I'll try to dig that up), but I'm sure switch-enum-1, switch-enum-2, and switch-enum-pr105273-doom-p_maputl.c. I *think* also switch-enum-5 and switch-enum-pr105273-doom-p_floor.c. > Can you add a copy of one of those tests that needs the patch, with an > explicit -fshort-enums, to ensure that regression testing is hitting > this case on all targets in the future? Ah, nice, that's a great idea, I wish I'd thought of that! Will do. -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer More tolerance and less prejudice are key for inclusion and diversity Excluding neuro-others for not behaving ""normal"" is *not* inclusive
