Am Montag, dem 06.11.2023 um 21:01 -0700 schrieb Jeff Law:
> 
> On 11/6/23 20:58, Hans-Peter Nilsson wrote:
> > > From: Martin Uecker <uec...@tugraz.at>
> > > Date: Tue, 31 Oct 2023 20:05:09 +0100
> > 
> > >      Reduce false positives for -Wnonnull for VLA parameters [PR98541]
> > >      
> > >      This patch limits the warning about NULL arguments to VLA
> > >      parameters declared [static n].
> > >      
> > >              PR c/98541
> > >      
> > >      gcc/
> > >              * gimple-ssa-warn-access.cc
> > >              (pass_waccess::maybe_check_access_sizes): For VLA bounds
> > >              in parameters, only warn about null pointers with 'static'.
> > >      
> > >      gcc/testsuite:
> > >              * gcc.dg/Wnonnull-4: Adapt test.
> > >              * gcc.dg/Wstringop-overflow-40.c: Adapt test.
> > 
> > This patch caused a testsuite regression: there's now an
> > "excess error" failure for gcc.dg/Wnonnull-4.c for 32-bit
> > targets (and 64-bit targets testing with a "-m32" option)
> > after your r14-5115-g6e9ee44d96e5.  It's logged as PR112419.
> It caused failures for just about every target ;(  Presumably it worked 
> on x86_64...

I do not think this is a true regression
just a problem with the test on 32-bit which somehow surfaced
due to the change.

The excess error is:

FAIL: gcc.dg/Wnonnull-4.c (test for excess errors)
Excess errors:
/home/tcwg-buildslave/workspace/tcwg_gnu_6/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.dg/Wnonnull-4.c:144:3:
 warning: 'fda_n_5' specified size 4294967256 exceeds maximum object size
2147483647 [-Wstringop-overflow=]

I think the warning was suppressed before due to the other (nonnull)
warning which I removed in this case.

I think the simple fix might be to to turn off -Wstringop-overflow.

Link to the change:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=6e9ee44d96e5bda8808dd9d8ccf58d2525383f6b


Martin







> 
> jeff

Reply via email to