On Wed, May 16, 2012 at 12:34:18PM -0700, Andrew Pinski wrote:
> When COND_EXPR was changed from GIMPLE_SINGLE_RHS to
> GIMPLE_TERNARY_RHS, get_maxval_strlen was not updated for that
> changed. With a patch which has a late PHIOPT produce COND_EXPR, I
> saw a couple of regressions (pr23484-chk.c and strncpy-chk.c).
>
> This patch fixes get_maxval_strlen for that change.
>
> OK for the trunk and 4.7 branch? Bootstrapped and tested on
> x86_64-linux-gnu with no regressions. And in 4.7.0 with the patch for
> PHIOPT producing COND_EXPR on both x86_64-linux-gnu and mipsisa64-elf.
Ok for both, but please fix up whitespace (on all lines you've changed
replace 8 spaces with tab, you use tabs in some lines and spaces in other
lines).
> ChangeLog:
> * gimple-fold.c (get_maxval_strlen): Move COND_EXPR handling under
> GIMPLE_ASSIGN.
Jakub
