Fixed, sorry for disturbing trunk
On Wed, Oct 11, 2023 at 3:50 PM Kito Cheng <kito.ch...@gmail.com> wrote: > > Oh, my bad seem like that was in later patch, let me fix now > > 钟居哲 <juzhe.zh...@rivai.ai> 於 2023年10月11日 週三 15:49 寫道： >> >> ../../../../gcc/gcc/config/riscv/riscv.cc:8142:18: error: >> ‘TARGET_MIN_VLEN_OPTS’ was not declared in this scope >> int min_vlen = TARGET_MIN_VLEN_OPTS (opts); >> >> >> >> ________________________________ >> juzhe.zh...@rivai.ai >> >> >> From: Kito Cheng >> Date: 2023-10-12 05:20 >> To: Jeff Law >> CC: Kito Cheng; gcc-patches; palmer; rdapp; juzhe.zhong >> Subject: Re: [PATCH v2 1/4] options: Define TARGET_<NAME>_P and >> TARGET_<NAME>_OPTS_P macro for Mask and InverseMask >> Thanks, committed, and just did one more check with x86 again, it >> works as well, hope no more awk portable issue this time :P >> >> On Tue, Oct 10, 2023 at 6:51 AM Jeff Law <jeffreya...@gmail.com> wrote: >> > >> > >> > >> > On 10/9/23 22:13, Kito Cheng wrote: >> > > We TARGET_<NAME>_P marcro to test a Mask and InverseMask with user >> > > specified target_variable, however we may want to test with specific >> > > gcc_options variable rather than target_variable. >> > > >> > > Like RISC-V has defined lots of Mask with TargetVariable, which is not >> > > easy to use, because that means we need to known which Mask are >> > > associate with >> > > which TargetVariable, so take a gcc_options variable is a better >> > > interface >> > > for such use case. >> > > >> > > gcc/ChangeLog: >> > > >> > > * doc/options.texi (Mask): Document TARGET_<NAME>_P and >> > > TARGET_<NAME>_OPTS_P. >> > > (InverseMask): Ditto. >> > > * opth-gen.awk (Mask): Generate TARGET_<NAME>_P and >> > > TARGET_<NAME>_OPTS_P macro. >> > > (InverseMask): Ditto. >> > OK assuming it passes a build cycle on x86 or some other common target. >> > >> > jeff >>
