On May 16, 2012, at 11:47 , Paolo Bonzini wrote: >> install-no-fixedincludes: installdirs install-host-nogcc \ >> ! install-target gcc-install-no-fixedincludes ... > This is missing in the ChangeLog.
Indeed. >> + install-no-fixedincludes: \ >> + stash-maybefixed-headers \ >> + stmp-int-hdrs \ >> + restore-header-stamps \ >> + install \ >> + restore-maybefixed-headers > > This is not safe for parallel build. Ah, right. > What about > install-no-fixedincludes: > ... contents of stash-maybefixed-headers ... > $(MAKE) $(FLAGS_TO_PASS) stmp-int-hdrs > ... contents of restore-header-stamps ... > $(MAKE) $(FLAGS_TO_PASS) install > ... contents of restore-maybefixed-headers ... > > ? Hmm, fine with me. I liked the use of separate targets to help provide a high level view of what the sequence is doing but each step is short enough for the inline inclusion not to damage readability. I'll post a followup patch+ChangeLog on the original thread. Thanks much for your prompt feedback :) Olivier
