> > On Tue, Sep 26, 2023 at 10:59 AM Patrick O'Neill <patr...@rivosinc.com> > > wrote: > >> stdint.h can be replaced with stdint-gcc.h to resolve some missing > >> system headers in non-multilib installations. > >> > >> Tested using glibc rv32gcv and rv64gcv on r14-4258-gc9837443075. > >> > >> gcc/ChangeLog: > >> > >> * config/riscv/riscv_vector.h (__RISCV_VECTOR_H): Replace > >> stdint.h with stdint-gcc.h > > I don't think this will work when testing an installed compiler which I do. > > > > Thanks, > > Andrew > In the riscv target testsuite (gcc.target/riscv) all occurrences of > #include <stdint.h> are currently constrained to the rvv/ subdirectory. > All non-vector tests use #include <stdint-gcc.h> rather than > #include <stdint.h>. Have you encountered any issues when testing > installations with non-vector tests?
I think the concern is to replace stdint.h with stdint-gcc.h for riscv_vector.h, that means users MAY include stdint-gcc.h *AND* stdint.h, stdint.h the later one generally is provided by libc, and stdint-gcc.h typically are not included. Other than the changes in "riscv_vector.h", everything else looks fine to me.
