Boolean logic is hard ... this fixes a bug in the previous re-org of clean/op_valid_in_sets.
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2012-05-14 Richard Guenther <rguent...@suse.de> PR tree-optimization/53340 * tree-ssa-pre.c (op_valid_in_sets): Fix error in last commit. Index: gcc/tree-ssa-pre.c =================================================================== --- gcc/tree-ssa-pre.c (revision 187449) +++ gcc/tree-ssa-pre.c (working copy) @@ -2007,8 +2007,8 @@ op_valid_in_sets (bitmap_set_t set1, bit if (op && TREE_CODE (op) == SSA_NAME) { unsigned int value_id = VN_INFO (op)->value_id; - if (!bitmap_set_contains_value (set1, value_id) - || (set2 && !bitmap_set_contains_value (set2, value_id))) + if (!(bitmap_set_contains_value (set1, value_id) + || (set2 && bitmap_set_contains_value (set2, value_id)))) return false; } return true;