On May 12, 2012, at 16:43 , David Edelsohn wrote:
> Please do not create another definition of the register number for LR.

 Oh ...

> Earlier in the file it is defined as R_LR. Dropping in a completely
> self-contained chunk with its own naming is confusing. LR_REGNO is
> fine, but please define the necessary registers at the beginning of
> the file and use them consistently throughout.

 Sure.
 
> Okay with that cleanup.

 Thanks for your prompt feedback :)

Reply via email to