Hi Jeff, On 2023/9/12 11:00, Jeff Law wrote:
I'd rather be consistent and make it policy that every insn has a type.
Since the type set here will not be used by sched pass (these insn pattern will not exit at shced pass since use define_insn_and_split with condition `TARGET_VECTOR && can_create_pseudo_p ()`), I think it is easy to cause misunderstanding and some problems are not easy to find (e.g. accidentally went through the sched pass should be assert error). In my opinion, assert in sched function can ensure that all insn pattern that reach sched pass have a type attribute. If not, it is a problem and needs to be located and checked. All insn patterns add type to allow assert to pass, but at the same time hide or ignore some problems. I don't know if there is a problem with my understanding, thank you.
-- Best, Lehua
