On 22.08.23 15:37, Jakub Jelinek wrote:
On Sun, Jul 23, 2023 at 04:15:21PM -0600, Sandra Loosemore wrote:
[...]
In the Fortran front end, most of the semantic processing happens during
the translation phase, so the parse phase just collects the intervening
statements, checks them for errors, and splices them around the loop body.
LGTM, but please let Tobias have a second look unless he has done so
already.
LGTM but some minor comments:
@@ -9764,13 +9820,12 @@ gfc_resolve_do_iterator (gfc_code *code, gfc_symbol
*sym, bool add_clause)
...
- c = c->block->next;
- }
+ c = find_nested_loop_in_chain (c->block->next);
+ }
Here the indentation of '}' is now in col 3 instead of 4.
* * *
I was wondering whether any removed error message (due to early return on error)
will cause missed error checking, but it looks as if all are covered elsewhere.
:-)
* * *
Can you update the implementation status - either as part of this patch as it is
the last in the series or as follow up? It feels good to see 'Y' getting added
there.
https://gcc.gnu.org/onlinedocs/libgomp/OpenMP-5_002e0.html
"Collapse of associated loops that are imperfectly nested loops"
alias libgomp/libgomp.texi in line 203.
Thanks,
Tobias
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
