Hi, on 2023/8/14 15:53, Jan-Benedict Glaw wrote: > On Fri, 2023-06-30 13:46:40 +0800, Kewen.Lin via Gcc-patches > <gcc-patches@gcc.gnu.org> wrote: >> Bootstrapped and regtested on x86_64-redhat-linux and >> powerpc64{,le}-linux-gnu. >> >> Is it ok for trunk? > [...] > >> diff --git a/gcc/recog.h b/gcc/recog.h >> index badf8e3dc1c..c6ef619c5dd 100644 >> --- a/gcc/recog.h >> +++ b/gcc/recog.h >> @@ -20,6 +20,9 @@ along with GCC; see the file COPYING3. If not see >> #ifndef GCC_RECOG_H >> #define GCC_RECOG_H >> >> +/* For enum tree_code ERROR_MARK. */ >> +#include "tree.h" >> + >> /* Random number that should be large enough for all purposes. Also define >> a type that has at least MAX_RECOG_ALTERNATIVES + 1 bits, with the extra >> bit giving an invalid value that can be used to mean "uninitialized". */ > > This part breaks for me (up-to-date amd64-linux host, cf. for example > http://toolchain.lug-owl.de/laminar/jobs/gcc-local/82): > > configure '--with-pkgversion=basepoints/gcc-14-3093-g4a8e6fa8016, built > at 1691996332' \ > --prefix=/var/lib/laminar/run/gcc-local/82/toolchain-install > \ > --enable-werror-always > \ > --enable-languages=all > \ > --disable-multilib > make V=1 all-gcc > > echo timestamp > s-preds-h > TARGET_CPU_DEFAULT="" \ > HEADERS="config/i386/i386-d.h" DEFINES="" \ > /bin/bash ../../gcc/gcc/mkconfig.sh tm_d.h > /var/lib/laminar/run/gcc-local/82/local-toolchain-install/bin/g++ -std=c++11 > -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti > -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings > -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported > -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros > -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H > -DGENERATOR_FILE -I. -Ibuild -I../../gcc/gcc -I../../gcc/gcc/build > -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include \ > -o build/genflags.o ../../gcc/gcc/genflags.cc > /var/lib/laminar/run/gcc-local/82/local-toolchain-install/bin/g++ -std=c++11 > -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables > -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual > -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual > -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror > -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ > -static-libgcc -o build/genflags \ > build/genflags.o build/rtl.o build/read-rtl.o build/ggc-none.o > build/vec.o build/min-insn-modes.o build/gensupport.o build/print-rtl.o > build/hash-table.o build/sort.o build/read-md.o build/errors.o > ../build-x86_64-pc-linux-gnu/libiberty/libiberty.a > /var/lib/laminar/run/gcc-local/82/local-toolchain-install/bin/g++ -std=c++11 > -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti > -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings > -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported > -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros > -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H > -DGENERATOR_FILE -I. -Ibuild -I../../gcc/gcc -I../../gcc/gcc/build > -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include \ > -o build/genconditions.o ../../gcc/gcc/genconditions.cc > /var/lib/laminar/run/gcc-local/82/local-toolchain-install/bin/g++ -std=c++11 > -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables > -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual > -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual > -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -Werror > -fno-common -DHAVE_CONFIG_H -DGENERATOR_FILE -static-libstdc++ > -static-libgcc -o build/genconditions \ > build/genconditions.o build/rtl.o build/read-rtl.o build/ggc-none.o > build/vec.o build/min-insn-modes.o build/gensupport.o build/print-rtl.o > build/hash-table.o build/sort.o build/read-md.o build/errors.o > ../build-x86_64-pc-linux-gnu/libiberty/libiberty.a > build/genconditions ../../gcc/gcc/common.md ../../gcc/gcc/config/i386/i386.md > > tmp-condmd.cc > /bin/bash ../../gcc/gcc/../move-if-change tmp-condmd.cc build/gencondmd.cc > echo timestamp > s-conditions > build/genpreds -c ../../gcc/gcc/common.md ../../gcc/gcc/config/i386/i386.md > > tmp-constrs.h > /bin/bash ../../gcc/gcc/../move-if-change tmp-constrs.h tm-constrs.h > echo timestamp > s-constrs-h > /var/lib/laminar/run/gcc-local/82/local-toolchain-install/bin/g++ -std=c++11 > -c -g -O2 -DIN_GCC -fno-exceptions -fno-rtti > -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings > -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported > -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros > -Wno-overlength-strings -Werror -fno-common -DHAVE_CONFIG_H > -DGENERATOR_FILE -I. -Ibuild -I../../gcc/gcc -I../../gcc/gcc/build > -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include \ > -o build/gencondmd.o build/gencondmd.cc > In file included from ../../gcc/gcc/tree.h:23, > from ../../gcc/gcc/recog.h:24, > from build/gencondmd.cc:40: > ../../gcc/gcc/tree-core.h:145:10: fatal error: all-tree.def: No such file or > directory > 145 | #include "all-tree.def"
Thanks for reporting and sorry for the breakage. This failure only gets exposed if all-tree.def isn't generated before compiling these gen*.cc including recog.h during the build. It explains why I didn't catch this failure before. I will check the existing practice and post a patch soon. BR, Kewen > | ^~~~~~~~~~~~~~ > compilation terminated. > make[1]: *** [Makefile:2929: build/gencondmd.o] Error 1 > make[1]: Leaving directory > '/var/lib/laminar/run/gcc-local/82/toolchain-build/gcc' > make: *** [Makefile:4992: all-gcc] Error 2 > > > Some dependency missing? > > MfG, JBG >