On Wed, 12 Jul 2023 at 16:05, Jeff Law <jeffreya...@gmail.com> wrote:
> > > On 7/12/23 06:48, Christoph Müllner wrote: > > On Wed, Jul 12, 2023 at 4:05 AM Jeff Law <jeffreya...@gmail.com> wrote: > >> > >> > >> > >> On 7/10/23 22:44, Christoph Muellner wrote: > >>> From: Christoph Müllner <christoph.muell...@vrull.eu> > >>> > >>> Recently, two identical XTheadCondMov tests have been added, which > both fail. > >>> Let's fix that by changing the following: > >>> * Merge both files into one (no need for separate tests for rv32 and > rv64) > >>> * Drop unrelated attribute check test (we already test for `th.mveqz` > >>> and `th.mvnez` instructions, so there is little additional value) > >>> * Fix the pattern to allow matching > >>> > >>> gcc/testsuite/ChangeLog: > >>> > >>> * gcc.target/riscv/xtheadcondmov-indirect-rv32.c: Moved to... > >>> * gcc.target/riscv/xtheadcondmov-indirect.c: ...here. > >>> * gcc.target/riscv/xtheadcondmov-indirect-rv64.c: Removed. > >> I thought this stuff got fixed recently. Certainly happy to see the > >> files merged though. Here's what I got from the July 4 run: > > > > I have the following with a GCC master from today > > (a454325bea77a0dd79415480d48233a7c296bc0a): > > > > FAIL: gcc.target/riscv/xtheadcondmov-indirect-rv32.c -O2 > > scan-assembler .attribute arch, > > "rv32i2p1_m2p0_a2p1_f2p2_d2p2_c2p0_zicsr2p0_zifencei2p0_xtheadcondmov1p0" > > FAIL: gcc.target/riscv/xtheadcondmov-indirect-rv64.c -O2 > > scan-assembler .attribute arch, > > "rv64i2p1_m2p0_a2p1_f2p2_d2p2_c2p0_zicsr2p0_zifencei2p0_xtheadcondmov1p0" > > > > With this patch the fails are gone. > Then it's fine with me :-) For the avoidance of all doubt: could I hear an "OK"? Thanks, Philipp.
