Committed, thanks Juzhe and Kito. Pan
-----Original Message----- From: Kito Cheng <kito.ch...@gmail.com> Sent: Wednesday, July 5, 2023 3:16 PM To: juzhe.zh...@rivai.ai Cc: Li, Pan2 <pan2...@intel.com>; gcc-patches <gcc-patches@gcc.gnu.org>; Robin Dapp <rdapp....@gmail.com>; jeffreyalaw <jeffreya...@gmail.com>; Wang, Yanzhang <yanzhang.w...@intel.com> Subject: Re: [PATCH v1] RISC-V: Use FRM_DYN when add the rounding mode operand LGTM On Wed, Jul 5, 2023 at 10:08 AM juzhe.zh...@rivai.ai <juzhe.zh...@rivai.ai> wrote: > > LGTM. > > > > juzhe.zh...@rivai.ai > > From: pan2.li > Date: 2023-07-04 20:26 > To: gcc-patches > CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng > Subject: [PATCH v1] RISC-V: Use FRM_DYN when add the rounding mode operand > From: Pan Li <pan2...@intel.com> > > This patch would like to take FRM_DYN const rtx as the rounding mode > operand according to the RVV spec, which takes the dyn as the only > rounding mode for floating-point. > > Signed-off-by: Pan Li <pan2...@intel.com> > > gcc/ChangeLog: > > * config/riscv/riscv-vector-builtins.cc > (function_expander::use_exact_insn): Use FRM_DYN instead of const0. > --- > gcc/config/riscv/riscv-vector-builtins.cc | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gcc/config/riscv/riscv-vector-builtins.cc > b/gcc/config/riscv/riscv-vector-builtins.cc > index 648c765a5d1..3a53b56effa 100644 > --- a/gcc/config/riscv/riscv-vector-builtins.cc > +++ b/gcc/config/riscv/riscv-vector-builtins.cc > @@ -3569,11 +3569,10 @@ function_expander::use_exact_insn (insn_code icode) > if (base->has_rounding_mode_operand_p ()) > add_input_operand (call_expr_nargs (exp) - 2); > - /* TODO: Currently, we don't support intrinsic that is modeling rounding > mode. > - We add default rounding mode for the intrinsics that didn't model > rounding > - mode yet. */ > + /* The RVV floating-point only support dynamic rounding mode in the > + FRM register. */ > if (opno != insn_data[icode].n_generator_args) > - add_input_operand (Pmode, const0_rtx); > + add_input_operand (Pmode, gen_int_mode (riscv_vector::FRM_DYN, Pmode)); > return generate_insn (icode); > } > -- > 2.34.1 > >
