On Tue, Jul 4, 2023 at 5:59 PM Thomas Schwinge <tho...@codesourcery.com> wrote:
>
> Hi!
>
> On 2013-01-24T10:14:58-0500, Diego Novillo <dnovi...@google.com> wrote:
> > [...] the patch [...] committed [...]
>
> This did clean up some things:
>
> > --- a/gcc/ggc-internal.h
> > +++ b/gcc/ggc-internal.h
> > @@ -55,8 +55,7 @@ extern struct ggc_pch_data *init_ggc_pch (void);
> > of an object. Update the ggc_pch_data structure with as much of
> > that information as is necessary. The bool argument should be true
> > if the object is a string. */
> > -extern void ggc_pch_count_object (struct ggc_pch_data *, void *, size_t,
> > bool,
> > - enum gt_types_enum);
> > +extern void ggc_pch_count_object (struct ggc_pch_data *, void *, size_t,
> > bool);
> >
> > /* Return the total size of the data to be written to hold all
> > the objects previously passed to ggc_pch_count_object. */
> > @@ -69,8 +68,7 @@ extern void ggc_pch_this_base (struct ggc_pch_data *,
> > void *);
> > /* Assuming that the objects really do end up at the address
> > passed to ggc_pch_this_base, return the address of this object.
> > The bool argument should be true if the object is a string. */
> > -extern char *ggc_pch_alloc_object (struct ggc_pch_data *, void *, size_t,
> > bool,
> > - enum gt_types_enum);
> > +extern char *ggc_pch_alloc_object (struct ggc_pch_data *, void *, size_t,
> > bool);
>
> > --- a/gcc/ggc-page.c
> > +++ b/gcc/ggc-page.c
>
> > @@ -2230,8 +2221,7 @@ init_ggc_pch (void)
> >
> > void
> > ggc_pch_count_object (struct ggc_pch_data *d, void *x ATTRIBUTE_UNUSED,
> > - size_t size, bool is_string ATTRIBUTE_UNUSED,
> > - enum gt_types_enum type ATTRIBUTE_UNUSED)
> > + size_t size, bool is_string ATTRIBUTE_UNUSED)
> > {
> > unsigned order;
> >
> > @@ -2274,8 +2264,7 @@ ggc_pch_this_base (struct ggc_pch_data *d, void *base)
> >
> > char *
> > ggc_pch_alloc_object (struct ggc_pch_data *d, void *x ATTRIBUTE_UNUSED,
> > - size_t size, bool is_string ATTRIBUTE_UNUSED,
> > - enum gt_types_enum type ATTRIBUTE_UNUSED)
> > + size_t size, bool is_string ATTRIBUTE_UNUSED)
> > {
> > unsigned order;
> > char *result;
>
> ..., but left in other 'ATTRIBUTE_UNUSED's.
>
> To enable another thing I'm working on, OK to push the attached clean-up
> "GGC: Remove unused 'bool is_string' arguments to
> 'ggc_pch_{count,alloc,write}_object'"?
OK.
Richard.
>
> Grüße
> Thomas
>
>
> -----------------
> Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
> München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
> Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
> München, HRB 106955
