On Wed, Jun 14, 2023 at 04:34:27PM +0200, Uros Bizjak wrote: > LGTM for the x86 part. I did my best, but those peephole2 patterns are > real PITA to be reviewed thoroughly. > > Maybe split out peephole2 pack to a separate patch, followed by a > testcase patch. This way, bisection would be able to point out if a > generic part or target-dependent part caused eventual regression.
Ok. Guess if it helps for bisection, I could even split the peephole2s to one peephole2 addition per commit and then the final patch would add the expanders and the generic code. Jakub