Committed, thanks Jeff. Pan
-----Original Message----- From: Gcc-patches <[email protected]> On Behalf Of Jeff Law via Gcc-patches Sent: Saturday, June 3, 2023 4:57 AM To: [email protected]; [email protected] Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected] Subject: Re: [PATCH V2] RISC-V: Fix warning in predicated.md On 6/2/23 03:33, [email protected] wrote: > From: Juzhe-Zhong <[email protected]> > > Notice there is warning in predicates.md: > ../../../riscv-gcc/gcc/config/riscv/predicates.md: In function ‘bool > arith_operand_or_mode_mask(rtx, machine_mode)’: > ../../../riscv-gcc/gcc/config/riscv/predicates.md:33:14: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] > (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > ../../../riscv-gcc/gcc/config/riscv/predicates.md:34:20: warning: comparison > between signed and unsigned integer expressions [-Wsign-compare] > || INTVAL (op) == GET_MODE_MASK (SImode)")))) > > gcc/ChangeLog: > > * config/riscv/predicates.md: Change INTVAL into UINTVAL. > > --- > gcc/config/riscv/predicates.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/riscv/predicates.md > b/gcc/config/riscv/predicates.md index d14b1ca30bb..04ca6ceabc7 100644 > --- a/gcc/config/riscv/predicates.md > +++ b/gcc/config/riscv/predicates.md > @@ -30,7 +30,7 @@ > (define_predicate "arith_operand_or_mode_mask" > (ior (match_operand 0 "arith_operand") > (and (match_code "const_int") > - (match_test "INTVAL (op) == GET_MODE_MASK (HImode) > + (match_test "UINTVAL (op) == GET_MODE_MASK (HImode) > || UINTVAL (op) == GET_MODE_MASK (SImode)")))) OK. jeff
