Committed, with Robin's suggestion for commit log, thanks Robin and Kito. Pan
-----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel....@gcc.gnu.org> On Behalf Of Kito Cheng via Gcc-patches Sent: Saturday, June 3, 2023 9:10 AM To: 钟居哲 <juzhe.zh...@rivai.ai> Cc: Robin Dapp <rdapp....@gmail.com>; gcc-patches <gcc-patches@gcc.gnu.org>; kito.cheng <kito.ch...@gmail.com>; palmer <pal...@dabbelt.com>; palmer <pal...@rivosinc.com>; jeffreyalaw <jeffreya...@gmail.com> Subject: Re: Re: [PATCH V2] RISC-V: Add pseudo vwmul.wv pattern to enhance vwmul.vv instruction optimizations Lgtm, thanks:) juzhe.zh...@rivai.ai <juzhe.zh...@rivai.ai> 於 2023年6月2日 週五 15:20 寫道: > Thanks. I am gonna wait for Jeff or Kito final approve. > > ------------------------------ > juzhe.zh...@rivai.ai > > > *From:* Robin Dapp <rdapp....@gmail.com> > *Date:* 2023-06-02 15:18 > *To:* juzhe.zh...@rivai.ai; gcc-patches <gcc-patches@gcc.gnu.org> > *CC:* rdapp.gcc <rdapp....@gmail.com>; kito.cheng > <kito.ch...@gmail.com>; Kito.cheng <kito.ch...@sifive.com>; palmer > <pal...@dabbelt.com>; palmer <pal...@rivosinc.com>; jeffreyalaw > <jeffreya...@gmail.com> > *Subject:* Re: [PATCH V2] RISC-V: Add pseudo vwmul.wv pattern to > enhance vwmul.vv instruction optimizations > >>> I like the code examples in general but find them hard to read at > >>> lengths > 5-10 or so. Could we condense this a bit? > > Ok, Do I need to send V2 ? Or condense the commit log when merged > > the > patch? > > Sure, just condense a bit. No need for V2. > > Regards > Robin > > >