On Wed, 24 May 2023, YunQiang Su wrote: > > or even: > > > > if (INTVAL (length) <= MIPS_MAX_MOVE_BYTES_STRAIGHT) > > ... > > else if (INTVAL (length) < 64 && optimize) > > ... > > > > I don't think this is a good option, since somebody may add some code, > and may break our logic.
There's no need to plan ahead for changes, which may never happen. As it stands reading through such flattened code here requires one step less to analyse as there's one nested level and one exit point less here. If more cases have to be added in the future, then whoever needs them will make any necessary adjustments to the structure (assuming minimal understanding how code works, which I think is a reasonable requirement for working on a compiler). Maciej