Oh, never mind, I mean you updated to use define_insn_and_split but comment still define_insn_and_split, but just ignore that if already committed
On Wed, May 24, 2023 at 3:42 PM juzhe.zh...@rivai.ai <juzhe.zh...@rivai.ai> wrote: > > > > > From: Juzhe-Zhong <juzhe.zh...@rivai.ai> > > > > This patch is adding mask logic auto-vectorization. > > define the pattern as "define_insn_and_split" to allow > > >don't forgot to update here ^^^^^ > > I notice I missed changeLog here. Is that you want me to fix in the > commit log? > > > > > juzhe.zh...@rivai.ai > > From: Kito Cheng > Date: 2023-05-24 15:31 > To: juzhe.zhong > CC: gcc-patches; kito.cheng; palmer; palmer; jeffreyalaw; rdapp.gcc; pan2.li > Subject: Re: [V2 COMMITTED] RISC-V: Add RVV mask logic auto-vectorization > LGTM, just one comment in git comment, no need v3, just commit with > the fix is fine :) > > On Wed, May 24, 2023 at 3:28 PM <juzhe.zh...@rivai.ai> wrote: > > > > From: Juzhe-Zhong <juzhe.zh...@rivai.ai> > > > > This patch is adding mask logic auto-vectorization. > > define the pattern as "define_insn_and_split" to allow > > don't forgot to update here ^^^^^ > > > combine PASS easily combine series instructions. > > > > For example: > > combine vmxor.mm + vmnot.m into vmxnor.mm > > > > Build success and regression PASS > > > > And committed. >
