On Wed, May 03, 2023 at 08:56:40PM +0100, Jonathan Wakely wrote:
> Do we want a #pragma to suppress -Wattribute-alias here?
I think that isn't needed, as the aliases use the same argument types
as the functions they are aliasing (did that because other
aliases in those files do it that way as well).
Other possibility would be
#pragma GCC diagnostic ignored "-Wattribute-alias"
from_chars_result
from_chars(const char* first, const char* last, _Float128& value,
chars_format fmt) noexcept
__attribute__((alias ("_ZSt10from_charsPKcS0_Ru9__ieee128St12chars_format")));
instead of the below snippet etc. (but as I said, I went for consistency).
> > --- libstdc++-v3/src/c++17/floating_from_chars.cc.jj 2023-04-13
> > 23:00:36.125459347 +0200
> > +++ libstdc++-v3/src/c++17/floating_from_chars.cc 2023-05-03
> > 17:24:45.121600206 +0200
> > @@ -1272,6 +1272,13 @@ from_chars(const char* first, const char
> > // fast_float doesn't support IEEE binary128 format, but we can use
> > strtold.
> > return from_chars_strtod(first, last, value, fmt);
> > }
> > +
> > +extern "C" from_chars_result
> > +_ZSt10from_charsPKcS0_RDF128_St12chars_format(const char* first,
> > + const char* last,
> > + __ieee128& value,
> > + chars_format fmt) noexcept
> > +__attribute__((alias
> > ("_ZSt10from_charsPKcS0_Ru9__ieee128St12chars_format")));
> > #elif defined(USE_STRTOF128_FOR_FROM_CHARS)
> > from_chars_result
> > from_chars(const char* first, const char* last, _Float128& value,
Jakub
