On Thu, Mar 30, 2023 at 11:58:19AM -0400, Andrew MacLeod wrote:
>
> On 3/30/23 09:41, Jakub Jelinek wrote:
> > On Wed, Mar 29, 2023 at 01:22:27PM -0400, Andrew MacLeod wrote:
> > > however, as seems to be the case often, better ranges result in, I now
> > > get:
> > >
> > > FAIL: 23_containers/vector/bool/allocator/copy.cc (test for excess errors)
> > Our middle-end warnings are just badly designed :(, the better value ranges
> > are, the more false positives they have.
> >
> > > commit 358d0ca44faf2e20fbacd0f74386308b5ca52cd4
> > > Author: Andrew MacLeod <amacl...@redhat.com>
> > > Date: Tue Mar 28 12:16:34 2023 -0400
> > >
> > > Add recursive GORI recompuations with a depth limit.
> > LGTM for trunk, let's do with the regression incrementally.
> > Or as Richard mentioned on IRC, one possibility would be to force this
> > param temporarily to 1 (or whatever matches previous behavior) for the
> > diagnostic range queries).
> >
> > You need a ChangeLog entry though...
> >
> Attached. I also removed the bogus warning in Walloc-13.c that no longer
> happens
>
> So incrementally deal with it.. what? just let it fail?
For today? Yes.
Ok for trunk.
> commit debb8ce1f9b9d5a72d88d0ae90a6b4da5130ff59
> Author: Andrew MacLeod <amacl...@redhat.com>
> Date: Tue Mar 28 12:16:34 2023 -0400
>
> Add recursive GORI recompuations with a depth limit.
>
> PR tree-optimization/109154
> gcc/
> * gimple-range-gori.cc (gori_compute::may_recompute_p): Add depth
> limit.
> * gimple-range-gori.h (may_recompute_p): Add depth param.
> * params.opt (ranger-recompute-depth): New param.
>
> gcc/testsuite/
> * gcc.dg/Walloca-13.c: Remove bogus warning that is now fixed.
Jakub
