On Wed, Mar 1, 2023 at 7:14 PM Costas Argyris via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > Hi > > It seems that the win32_spawn function in libiberty/pex-win32.c is leaking > the cmdline buffer in 2/3 exit scenarios (it is only free'd in 1/3). The > problem here is that the cleanup code is written 3 times, one at each exit > scenario. > > The proposed attached refactoring has the cleanup code appearing just once > and is executed for all exit scenarios, reducing the likelihood of such > leaks in the future.
One could imagine that CreateProcess in case of success takes ownership of the buffer pointed to by cmdline? If you can confirm it is not then the patch looks OK to me. Thanks, Richard. > Thanks, > Costas
