Tejas Belagod <tejas.bela...@arm.com> writes:
> Transitive closures of architectural extensions have to be manually maintained
> for AARCH64_OPT_EXTENSION list. Currently aes, sha2 and sha3 extensions add
> AARCH64_FL_SIMD has their dependency - this does not automatically pull in the
> transitive dependence of AARCH64_FL_FP from AARCH64_FL_SIMD's definition. As
> described the transitive closure/dependence has to be maintained manually.
> This patch adds AARCH64_FL_FP to each of these crypto extensions' dependence
> set. Automatic transitive closure maintenance is fixed on trunk in commit
> 11a113d501ff64fa4843e28d0a21b3f4e9d0d3de.
>
> gcc/ChangeLog:
>
> * config/aarch64/aarch64-option-extensions.def (aes, sha2, sha3):
> Update AARCH64_OPT_EXTENSION definition of architectural dependence for
> defintion of aes, sha2 and sha3 with AARCH64_FL_FP.
OK, thanks.
Richard
> ---
> gcc/config/aarch64/aarch64-option-extensions.def | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/gcc/config/aarch64/aarch64-option-extensions.def
> b/gcc/config/aarch64/aarch64-option-extensions.def
> index b4d0ac8b600..88cefc20022 100644
> --- a/gcc/config/aarch64/aarch64-option-extensions.def
> +++ b/gcc/config/aarch64/aarch64-option-extensions.def
> @@ -118,19 +118,19 @@ AARCH64_OPT_EXTENSION("dotprod", AARCH64_FL_DOTPROD,
> AARCH64_FL_SIMD, 0, \
>
> /* Enabling "aes" also enables "simd".
> Disabling "aes" disables "aes" and "sve2-aes'. */
> -AARCH64_OPT_EXTENSION("aes", AARCH64_FL_AES, AARCH64_FL_SIMD, \
> - AARCH64_FL_SVE2_AES, false, "aes")
> +AARCH64_OPT_EXTENSION("aes", AARCH64_FL_AES, AARCH64_FL_SIMD | \
> + AARCH64_FL_FP, AARCH64_FL_SVE2_AES, false, "aes")
>
> /* Enabling "sha2" also enables "simd".
> Disabling "sha2" just disables "sha2". */
> -AARCH64_OPT_EXTENSION("sha2", AARCH64_FL_SHA2, AARCH64_FL_SIMD, 0, false, \
> - "sha1 sha2")
> +AARCH64_OPT_EXTENSION("sha2", AARCH64_FL_SHA2, AARCH64_FL_SIMD | \
> + AARCH64_FL_FP, 0, false, "sha1 sha2")
>
> /* Enabling "sha3" enables "simd" and "sha2".
> Disabling "sha3" disables "sha3" and "sve2-sha3". */
> AARCH64_OPT_EXTENSION("sha3", AARCH64_FL_SHA3, AARCH64_FL_SIMD | \
> - AARCH64_FL_SHA2, AARCH64_FL_SVE2_SHA3, false, \
> - "sha3 sha512")
> + AARCH64_FL_SHA2 | AARCH64_FL_FP, AARCH64_FL_SVE2_SHA3, \
> + false, "sha3 sha512")
>
> /* Enabling "sm4" also enables "simd".
> Disabling "sm4" disables "sm4" and "sve2-sm4". */
