cc Richard. thanks,
David On Mon, Apr 16, 2012 at 3:24 AM, Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote: > As reported in PR testsuite/52948, several plugin testcases were failing > since the removal of TODO_dump_func: > > UNRESOLVED: selfassign.c compilation, -I. > -I/vol/gcc/src/hg/trunk/local/gcc/testsuite > -I/vol/gcc/src/hg/trunk/local/gcc/testsuite/../../gcc > -I/var/gcc/regression/trunk/11-gcc/build/gcc/testsuite/g++/../../../gcc > -I/vol/gcc/src/hg/trunk/local/gcc/testsuite/../../include > -I/vol/gcc/src/hg/trunk/local/gcc/testsuite/../../libcpp/include > -I/vol/gcc/include -I/vol/gcc/include -I/vol/gcc/include > -I/var/gcc/regression/trunk/11-gcc/build/gcc/testsuite/g++/../../../intl -O > -DIN_GCC -fPIC -shared > > I have no idea why this has been missed when testing the removal patch, > because the failures are very prominent in mail-report.log (maybe > because the incorrectly show up as UNRESOLVED instead of FAIL). > > This patch fixes this by removing the uses of TODO_dump_func from the > affected plugins. > > At the same time, I'm finally fixing some issues with the plugin tests > that have annoyed me for quite some time: > > * The tests should log the full (relative) path to the testcase, not > only the basenames. > > * Using unresolved to report failures to compile the plugins is wrong: > this should be fail instead, and the pass case needs to be logged as > well. > > * There's no point in logging the options used to compile the plugin: > they are completely internal to plugin-support.exp and not in any way > influenced by the testsuite drivers. > > There's one issue I didn't fix due to the large number of (bad) > precedents in the testsuite: > > * If a plugin fails to compile, the compilations using it should become > unresolved instead of just returning early. > > Bootstrapped without regressions on i386-pc-solaris2.11, installed on > mainline. > > Rainer > > > 2012-04-14 Rainer Orth <r...@cebitec.uni-bielefeld.de> > > gcc/testsuite: > * lib/plugin-support.exp (plugin-test-execute): Properly determine > testcase name. > Use fail, pass instead of unresolved. > Don't log $optstr. > > PR testsuite/52948 > * g++.dg/plugin/dumb_plugin.c (pass_dumb_plugin_example): Remove > TODO_dump_func. > * g++.dg/plugin/selfassign.c (pass_warn_self_assign): Likewise. > * gcc.dg/plugin/one_time_plugin.c (one_pass): Likewise. > * gcc.dg/plugin/selfassign.c (pass_warn_self_assign): Likewise. > > > > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University >
