On Fri, 23 Dec 2022, Jose E. Marchesi via Gcc-patches wrote:
> This patch adds an Atom feed for GCC news

I was going to approve, would like to see a bit consensus with others 
though.


For now some review:

>  <!-- Note: We usually want to rotate news to the "old news" page when
>       it's more than 12 months old or the News pane on this page has
> -     become longer than the parallel one, whatever happens first. 
> +     become longer than the parallel one, whatever happens first.
> +
> +     Note: There is an Atom feed in news.xml, which is aggregated by
> +     some news aggregators and "planets".  It is likely you want to
> +     add a new item there with the good news.
>  -->

I recommend switching the two notes. The one on the feed feels more 
important since that aspect is easier to miss than the required rotation 
(which visually presents itself when one looks at our web site).

> +++ b/htdocs/news.xml
> @@ -0,0 +1,28 @@
> +<?xml version="1.0" encoding="UTF-8"?>
> +
> +<rss version="2.0">
> +  <channel>
> +    <title>News about the GNU Compiler Collection</title>
> +    <link>https://gcc.gnu.org</link>
> +    <description>
> +      The GNU Compiler Collection includes front ends for C, C++,
> +      Objective-C, Fortran, Ada, Go, and D, as well as libraries for
> +      these languages (libstdc++,...). GCC was originally written as
> +      the compiler for the GNU operating system. The GNU system was
> +      developed to be 100% free software, free in the sense that it
> +      respects the user's freedom.
> +    </description>

Looks like we should think of updating our description (though that's 
beyond the scope of your patch), for example talking more about the many 
platforms supported and less about history.

> +    <item>
> +      <title>GCC BPF in Compiler Explorer</title>
> +      <link>https://godbolt.org</link>
> +      <description>
> +        Support for a nightly build of the bpf-unknown-none-gcc
> +        compiler has been contributed to Compiler Explorer (aka
> +        godbolt.org) by Marc Poulhiès

Would this be full sentences (with a full stop)?

When one adds additional entries, do those come at the beginning or the 
end? (Could there be a comment?)

> +      <pubDate>Fri, 23 December 2022 11:00:00 CET</pubDate>

On the web site we use ISO dates - any issues with that?

And does the feed require time of day, or could we omit that? (Especially 
with different timezones we all are in?)

Gerald

Reply via email to