On 11/21/22 13:17, Jakub Jelinek wrote:
On Mon, Nov 21, 2022 at 12:59:15PM +0100, Christophe Lyon wrote:
My previous patch to add a sanity check to genmultilib actually
checked the number of dirnames with the number of "sets of options"
rather than the number of options, thus breaking the build on some
targets.
To avoid duplicating once more the loop that constructs the sed
patterns, this patch checks that the current dirname/osdirname is not
empty in the existing loops.
Are there targets where:
if [ "$1" != "${opt}" ]; then
is "legally" executed with an empty $1? (and thus where this patch
would incorrectly trigger an error?)
Dunno, let's try your patch. And if that triggers on something
valid then the next step would be just to revert the sanity checks
completely.
Agreed.
* genmultilib: Fix options and dirnames/osdirnames sanity
check.
This won't get through the pre-commit hook, the second line
should be indented just by tab and nothing further.
Thanks for catching this.
Pushed.
Christophe
Jakub
