On 10/25/22 08:33, Jørgen Kvalsvik wrote:
Gentle ping. I have a tuned the summary output slightly (decisions covered ->
condition outcomes covered) already.
Sorry for a small delay, I'm working on it.
One general issue I noticed is you use an invalid coding style, where you use 4
spaces
for each level. Plus see the indentation for '{', '}':
diff --git a/gcc/tree-profile.cc b/gcc/tree-profile.cc
index 0b537d64d97..b661ed92045 100644
--- a/gcc/tree-profile.cc
+++ b/gcc/tree-profile.cc
@@ -553,11 +553,12 @@ masking_vectors (conds_ctx& ctx, array_slice<basic_block>
blocks,
body[0] = body.pop ();
for (const basic_block b : body)
- {
+ {
for (edge e1 : b->preds)
- for (edge e2 : b->preds)
- {
- const basic_block top = e1->src;
+ for (edge e2 : b->preds)
+ {
+ const basic_block top = e1->src;
+...
const basic_block bot = e2->src;
const unsigned cond = e1->flags & e2->flags & (EDGE_CONDITION);
Link: https://gcc.gnu.org/codingconventions.html
What editor do you use?
Cheers,
Martin
